stable_sort_primitive: print the type that is being sorted in the lint message #5935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
matthiaskrgr
force-pushed
the
unstable_sort_ty_name
branch
3 times, most recently
from
94b65d7
to
331e07b
Compare
flip1995
reviewed
Aug 24, 2020
| @@ -111,9 +112,10 @@ impl LateLintPass<'_> for StableSortPrimitive { | |||
| STABLE_SORT_PRIMITIVE, | |||
| expr.span, | |||
| format!( | |||
| "used {} instead of {}", | |||
| "used {} instead of {} to sort primitive type {}", | |||
There was a problem hiding this comment.
NIT:
Suggested change
| "used {} instead of {} to sort primitive type {}", | |
| "used {} instead of {} to sort primitive type `{}`", |
r=me with this change and reference files updated.
flip1995
approved these changes
Aug 24, 2020
matthiaskrgr
force-pushed
the
unstable_sort_ty_name
branch
from
331e07b
to
e9964f2
Compare
|
@bors r=flip1995 |
|
📌 Commit e9964f2 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: stable_sort_primitive: print the type that is being sorted in the lint message