Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negative in PRECEDENCE lint #5928

Merged
merged 1 commit into from Aug 20, 2020
Merged

Fix false negative in PRECEDENCE lint #5928

merged 1 commit into from Aug 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2020

Extend the lint to handle chains of methods combined with unary negation.

Closes #5924

changelog: Fix false negative in PRECEDENCE lint

Extend the lint to handle chains of methods combined with unary negation.

Closes #5924
@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 20, 2020
@ebroto
Copy link
Member

ebroto commented Aug 20, 2020

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Aug 20, 2020

📌 Commit c236c0f has been approved by ebroto

@bors
Copy link
Collaborator

bors commented Aug 20, 2020

⌛ Testing commit c236c0f with merge 4104611...

@ebroto ebroto changed the title Fix false positive in PRECEDENCE lint Fix false negative in PRECEDENCE lint Aug 20, 2020
@ebroto ebroto removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 20, 2020
@bors
Copy link
Collaborator

bors commented Aug 20, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing 4104611 to master...

@bors bors merged commit 4104611 into rust-lang:master Aug 20, 2020
@ghost ghost deleted the fix-5924 branch August 20, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling of the precedence lint is incorrect for chained expressions
4 participants