Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reprise: new lint: Unintentional return of unit from closures expecting Ord #5737

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Reprise: new lint: Unintentional return of unit from closures expecting Ord #5737

merged 1 commit into from
Jul 14, 2020

Commits on Jul 14, 2020

  1. new lint: Returning unit from closures expecting Ord 

    This lint catches cases where the last statement of a closure expecting
an instance of Ord has a trailing semi-colon. It compiles since the
closure ends up return () which also implements Ord but causes
unexpected results in cases such as sort_by_key.

Fixes #5080

reprise: rebase, update and address all concerns
    @matthiaskrgr @Uriopass
    matthiaskrgr authored and Uriopass committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    1267909 View commit details
    Browse the repository at this point in the history