Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mismatched_target_os lint #5506

Merged
merged 5 commits into from
Apr 27, 2020
Merged

Implement mismatched_target_os lint #5506

merged 5 commits into from
Apr 27, 2020

Commits on Apr 26, 2020

  1. Implement mismatched_target_os lint

    @ebroto
    ebroto committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    149f6d6 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from PR review 

    - Show just one error message with multiple suggestions in case of
  using multiple times an OS in target family position
- Only suggest #[cfg(unix)] when the OS is in the Unix family
- Test all the operating systems
    @ebroto
    ebroto committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    d24a106 View commit details
    Browse the repository at this point in the history

  3. Use the span of the attribute for the error message

    @ebroto
    ebroto committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    ce50e42 View commit details
    Browse the repository at this point in the history

  4. Remove some OSes from the test to comply with stderr line limit

    @ebroto
    ebroto committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    4a405c9 View commit details
    Browse the repository at this point in the history

  5. Split tests in unix/non-unix

    @ebroto
    ebroto committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    303e7d1 View commit details
    Browse the repository at this point in the history