Disallow bit-shifting in integer_arithmetic #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
changed the title
michaelsproul
force-pushed
the
integer-arithmetic
branch
from
69f554d
to
ffeaef7
Compare
This comment has been minimized.
This comment has been minimized.
michaelsproul
changed the title
|
☔ The latest upstream changes (presumably #5438) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
added
the
S-waiting-on-author
michaelsproul
force-pushed
the
integer-arithmetic
branch
from
ffeaef7
to
04be286
Compare
michaelsproul
changed the title
With this change, the lint checks all operations that are defined as being capable of overflow in the Rust Reference.
michaelsproul
force-pushed
the
integer-arithmetic
branch
from
04be286
to
23df4a0
Compare
|
Updated and rebased |
flip1995
added
S-waiting-on-review
flip1995
approved these changes
Apr 15, 2020
flip1995
added
S-waiting-on-bors
|
Thanks! Waiting for rustup. |
|
@bors r+ rollup |
|
📌 Commit 23df4a0 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1, this pull request will be tested once the tree is reopened |
bors
added a commit
that referenced
this pull request
Apr 15, 2020
Rollup of 5 pull requests Successful merges: - #5226 (Add lint for explicit deref and deref_mut method calls) - #5248 (Add lint on large non scalar const) - #5430 (Disallow bit-shifting in integer_arithmetic) - #5466 (large_enum_variant: Report sizes of variants) - #5468 (Zero single char names) Failed merges: r? @ghost changelog: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
integer_arithmeticlint detect all the operations that are defined as being capable of overflow in the Rust Reference, by also linting for bit-shifting operations (<<,>>).changelog: Disallow bit-shifting in
integer_arithmetic