Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch back to latest official RTIM release #4668

Merged
merged 4 commits into from
Oct 15, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 15, 2019

Closes #4666

changelog: none

@tesuji
Copy link
Contributor Author

tesuji commented Oct 15, 2019

r? @phansch

@flip1995
Copy link
Member

@bors r+ p=10

@bors
Copy link
Collaborator

bors commented Oct 15, 2019

📌 Commit 0b39946 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Oct 15, 2019

⌛ Testing commit 0b39946 with merge 7df24c3...

bors added a commit that referenced this pull request Oct 15, 2019
 build: switch back to latest official RTIM release

Closes #4666

changelog: none
@bors
Copy link
Collaborator

bors commented Oct 15, 2019

💔 Test failed - checks-travis

@tesuji
Copy link
Contributor Author

tesuji commented Oct 15, 2019

Hmm, ICE in use_self lint ?

@mati865
Copy link
Contributor

mati865 commented Oct 15, 2019

Could be rustc change, maybe cx is not longer right in some cases?

@flip1995
Copy link
Member

flip1995 commented Oct 15, 2019

I have a test case for this, but no fix yet. Will open a PR soon (#4671).

Problem is building this span:

let last_segment = last_segment.unwrap_or_else(|| path.segments.last().expect(SEGMENTS_MSG));
// Path segments only include actual path, no methods or fields.
let last_path_span = last_segment.ident.span;
// Only take path up to the end of last_path_span.
let span = path.span.with_hi(last_path_span.hi());

when the path span is in a macro in another file, but the span of the last segment is in the current file.

@phansch
Copy link
Member

phansch commented Oct 15, 2019

@bors retry

@bors
Copy link
Collaborator

bors commented Oct 15, 2019

⌛ Testing commit 0b39946 with merge ddb5cb7...

bors added a commit that referenced this pull request Oct 15, 2019
 build: switch back to latest official RTIM release

Closes #4666

changelog: none
@bors
Copy link
Collaborator

bors commented Oct 15, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing ddb5cb7 to master...

@bors bors merged commit 0b39946 into rust-lang:master Oct 15, 2019
@tesuji tesuji deleted the update-rtim branch October 15, 2019 19:09
@bors bors mentioned this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point RTIM to latest release
5 participants