account for doc visibility

[llogiq]

This fixes #4608.

Also I noticed that the lint failed to look at trait and impl items. There's a small bit of fallout in the code, too, but not enough to warrant its own commit.

changelog: check docs of trait items and impl items, also make missing_safety_doc account for visibility

[flip1995]

Thanks!

I'm wondering if we should create a lint group for documentation lints 🤔

@bors r+

[bors]

📌 Commit daddf80 has been approved by flip1995

[bors]

☔ The latest upstream changes (presumably #4603) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

1. git checkout doc-visibility (switch to your branch)
2. git fetch upstream master (retrieve the latest master)
3. git rebase upstream/master -p (rebase on top of it)
4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
5. git push self doc-visibility --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging clippy_lints/src/lib.rs
Auto-merging clippy_lints/src/doc.rs
CONFLICT (content): Merge conflict in clippy_lints/src/doc.rs
Automatic merge failed; fix conflicts and then commit the result.

[llogiq]

Failure was a network error at Travis.

[flip1995]

@bors r+

[bors]

📌 Commit e3f143f has been approved by flip1995

[bors]

⌛ Testing commit e3f143f with merge e1a851d...

[bors]

💔 Test failed - status-appveyor

[llogiq]

Same problem as #4592.

[flip1995]

Yeah, we got a pile of approved PRs that couldn't be merged because of that:

[bors]

⌛ Testing commit e3f143f with merge b690cdb...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing b690cdb to master...