Extend use_self to check constructor
#4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust did not allow this before.
|
LGTM! Does this fix #3567, too? |
phansch
approved these changes
Sep 9, 2019
|
I checked #3567 on master and it was already fixed. I'll make a pull request to close it (with a regression test) after this gets merged. |
|
@bors r+ thanks for checking =) |
|
📌 Commit 31fbff2 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 10, 2019
Extend `use_self` to check constructor Rust did not allow this before. changelog: Extend `use_self` to check constructor
|
☀️ Test successful - checks-travis, status-appveyor |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust did not allow this before.
changelog: Extend
use_selfto check constructor