Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast_lossless false positive in impl const fn #4473

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Aug 30, 2019

Fixes #3656 (comment)

changelog: Fix false positive in cast_lossless

@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 30, 2019

📌 Commit fb1ae17 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Aug 30, 2019

⌛ Testing commit fb1ae17 with merge 581ebe0...

bors added a commit that referenced this pull request Aug 30, 2019
Fix cast_lossless false positive in impl const fn

Fixes #3656 (comment)

changelog: Fix false positive in `cast_lossless`
@flip1995
Copy link
Member

Oh wait. #4475. Canceling the travis run, to keep the queue clean.

@bors
Copy link
Collaborator

bors commented Aug 30, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Member Author

phansch commented Aug 30, 2019

@bors retry

@bors
Copy link
Collaborator

bors commented Aug 30, 2019

⌛ Testing commit fb1ae17 with merge a3fcaee...

bors added a commit that referenced this pull request Aug 30, 2019
Fix cast_lossless false positive in impl const fn

Fixes #3656 (comment)

changelog: Fix false positive in `cast_lossless`
@bors
Copy link
Collaborator

bors commented Aug 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing a3fcaee to master...

@bors bors merged commit fb1ae17 into rust-lang:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cast_lossless is triggered on const fn
3 participants