Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate invalid_ref lint #4368

Merged
merged 2 commits into from
Aug 11, 2019
Merged

deprecate invalid_ref lint #4368

merged 2 commits into from
Aug 11, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 9, 2019

This fixes the invalid_ref lint test to no longer fail when rust-lang/rust#63346 lands. I also fixed the lint itself, because its wording made no sense: there is no "reference to zeroed/uninitialized memory" here.

changelog: none

@RalfJung RalfJung mentioned this pull request Aug 9, 2019
Merged
@RalfJung
Copy link
Member Author

RalfJung commented Aug 9, 2019 •
edited
Loading

The clippy lint is also almost entirely subsumed by the new rustc lint added in that PR, so maybe it should just be removed?

("Almost" because I didn't bother warning for direct uses of the intrinsics. They are perma-unstable and scheduled for removal, after all.)

@RalfJung
Copy link
Member Author

RalfJung commented Aug 9, 2019

Windows CI failure doesn't look like I caused it?

@RalfJung RalfJung closed this Aug 10, 2019
@RalfJung RalfJung reopened this Aug 10, 2019
@RalfJung
Copy link
Member Author

@Manishearth could you take a look? This blocks a new rustc lint that would be really nice to have in the beta.

@Manishearth
Copy link
Member

The clippy lint is also almost entirely subsumed by the new rustc lint added in that PR, so maybe it should just be removed?

Yes, just move it to the list of deprecated lints

@RalfJung
Copy link
Member Author

@Manishearth done.

@RalfJung RalfJung changed the title fix invalid_ref lint and prepare for invalid_value lint deprecate invalid_ref lint Aug 11, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Aug 11, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 11, 2019

📌 Commit 2dcce60 has been approved by oli-obk

@bors
Copy link
Collaborator

bors commented Aug 11, 2019

⌛ Testing commit 2dcce60 with merge 31feb5b...

bors added a commit that referenced this pull request Aug 11, 2019
@bors
Auto merge of #4368 - RalfJung:invalid_ref, r=oli-obk
31feb5b 
deprecate invalid_ref lint

This fixes the `invalid_ref` lint test to no longer fail when rust-lang/rust#63346 lands.  I also fixed the lint itself, because its wording made no sense: there is no "reference to zeroed/uninitialized memory" here.

changelog: none
@phansch
Copy link
Member

phansch commented Aug 11, 2019

Also needs ./util/dev update_lints

@bors
Copy link
Collaborator

bors commented Aug 11, 2019

💔 Test failed - checks-travis

@RalfJung
Copy link
Member Author

@phansch done.

@bors r=oli-obk (let's see if I can do this)

@bors
Copy link
Collaborator

bors commented Aug 11, 2019

@RalfJung: 🔑 Insufficient privileges: Not in reviewers

@oli-obk
Copy link
Contributor

oli-obk commented Aug 11, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 11, 2019

📌 Commit 40fea7a has been approved by oli-obk

@bors
Copy link
Collaborator

bors commented Aug 11, 2019

⌛ Testing commit 40fea7a with merge 72da101...

bors added a commit that referenced this pull request Aug 11, 2019
@bors
Auto merge of #4368 - RalfJung:invalid_ref, r=oli-obk
72da101 
deprecate invalid_ref lint

This fixes the `invalid_ref` lint test to no longer fail when rust-lang/rust#63346 lands.  I also fixed the lint itself, because its wording made no sense: there is no "reference to zeroed/uninitialized memory" here.

changelog: none
@oli-obk
Copy link
Contributor

oli-obk commented Aug 11, 2019

@bors delegate+

@bors
Copy link
Collaborator

bors commented Aug 11, 2019

✌️ @RalfJung can now approve this pull request

@bors
Copy link
Collaborator

bors commented Aug 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 72da101 to master...

@bors bors merged commit 40fea7a into rust-lang:master Aug 11, 2019
@bors bors mentioned this pull request Aug 11, 2019
Merged
@RalfJung RalfJung deleted the invalid_ref branch November 2, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @Manishearth @oli-obk @bors @phansch