trivially_copy_pass_by_ref: print size of type and limit in the lint message #4071
Conversation
|
Note: this is still work in progress, I'll have to make the sure the test passes on different platforms, but wanted some earlier feedback on the general idea. Perhaps this will help: https://rust-lang.github.io/rustc-guide/tests/adding.html#normalization |
|
I like the idea, but I think the diagnostic should be more verbose in explaining the sizes. Basically I think there should be no need to go to the documentation to understand the lint the first time one sees it. |
matthiaskrgr
changed the title
|
I updated the test to use normalized output! |
|
Hm, looks like |
matthiaskrgr
added
the
S-waiting-on-review
|
bump? |
|
@bors r+ |
|
📌 Commit 5d58163 has been approved by |
trivially_copy_pass_by_ref: print size of type and limit in the lint message changelog: trivially_copy_pass_by_ref: print size of type and limit in the lint message
|
☀️ Test successful - checks-travis, status-appveyor |
changelog: trivially_copy_pass_by_ref: print size of type and limit in the lint message