Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix if_then_some_else_none sugg missing closure intro #13409

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

lukaslueg
Copy link
Contributor

Fixes #13407

#13407 works in current stable. The suggestion-generating code got trampled over in 0532104 :-)

changelog: [if_then_some_else_none]: Fix missing closure in suggestion

@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 17, 2024
Copy link

@SpriteOvO SpriteOvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to suggest then_some(val) if val is a constant and doesn't need to lazy-eval?

@lukaslueg
Copy link
Contributor Author

@SpriteOvO, clippy::unnecessary_lazy_evaluations will fire on the suggestion, as it did before 0532104, and suggest then_some(true)

Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@dswij
Copy link
Member

dswij commented Sep 22, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 22, 2024

📌 Commit c3d58cd has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 22, 2024

⌛ Testing commit c3d58cd with merge 612ae35...

@bors
Copy link
Collaborator

bors commented Sep 22, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 612ae35 to master...

@bors bors merged commit 612ae35 into rust-lang:master Sep 22, 2024
8 checks passed
@lukaslueg lukaslueg deleted the issue13407 branch September 22, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if_then_some_else_none invalid suggestion
5 participants