Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc for while_let_loop #13379

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

alex-semenyuk
Copy link
Member

Fix doc for while_let_loop

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 11, 2024
@@ -188,22 +188,22 @@ declare_clippy_lint! {
/// The `while let` loop is usually shorter and more
/// readable.
///
/// ### Known problems
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referred issue was closed long time ago, so remove it, this this lint has some issues which can be found at section Related Issues

@dswij
Copy link
Member

dswij commented Sep 11, 2024

Thank you! @bors r+

@bors
Copy link
Collaborator

bors commented Sep 11, 2024

📌 Commit 49a5018 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 11, 2024

⌛ Testing commit 49a5018 with merge 78bdd45...

@bors
Copy link
Collaborator

bors commented Sep 11, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 78bdd45 to master...

@bors bors merged commit 78bdd45 into rust-lang:master Sep 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants