Fix [needless_return] false negative
#13214
Conversation
…ws a value Fixes rust-lang#12907 changelog: Fix [`needless_return`] false negative when returned expression borrows a value
rustbot
added
the
S-waiting-on-review
|
Looks good to me, thanks! Let's just wait for the assigned reviewer to take a look before approving. |
| fn issue12907() -> String { | ||
| return "".split("").next().unwrap().to_string(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this just needs a test for the mentioned RefCell or any other type that fails to compile. But I think the significant drop check is adequate
There is the rustc_insigificant_dtor attribute. (I didn't even know this existed before checking.) This is applied to certain types like Rc, HashMap, and array::IntoIter. Not sure whether this attribute changes the behavior (i.e., compiling would succeed) but it'd be a good idea to check.
There was a problem hiding this comment.
I think this just needs a test for the mentioned
RefCellor any other type that fails to compile. But I think the significant drop check is adequate
So should i delete the test then?
Not sure whether this attribute changes the behavior (i.e., compiling would succeed) but it'd be a good idea to check.
Yes, it compiles with the rustc_insigificant_dtor attribute and the lint is triggered.
There was a problem hiding this comment.
No I meant the only change it needs
There was a problem hiding this comment.
There is already a very similar test to the one mentioned:
fn temporary_outlives_local() -> String {
let x = RefCell::<String>::default();
return x.borrow().clone();
}There was a problem hiding this comment.
Yeah that does the same thing 👍 missed that before
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fixes #12907
changelog: Fix [
needless_return] false negative when returned expression borrows a value.