Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add applicability filter to lint list page #12655

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

SpencerAWill
Copy link
Contributor

changelog: Add applicability filter to lint list website.
Fixes #7958

Desktop view:
image

Mobile view:
image

@rustbot
Copy link
Collaborator

rustbot commented Apr 9, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 9, 2024
@SpencerAWill SpencerAWill changed the title Add applicability filter Add applicability filter to lint list page Apr 9, 2024
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny NIT, the rest looks good to me. Thank you for the addition :D

util/gh-pages/script.js Outdated Show resolved Hide resolved
Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com>
@xFrednet
Copy link
Member

The changes look good to me, thank you! :D

@bors r+

@xFrednet
Copy link
Member

xFrednet commented Jun 18, 2024

@bors retry

@xFrednet
Copy link
Member

@bors ping

@xFrednet
Copy link
Member

@bors r-

@xFrednet
Copy link
Member

@bors r+

@xFrednet
Copy link
Member

Sorry, I totally missed that @bors didn't merge this PR, I thought this was already merged 🙈 I've asked the infra team to resync the bot to hopefully fix this :D

@xFrednet
Copy link
Member

Let's test closing and opening it again

@xFrednet xFrednet closed this Jun 18, 2024
@xFrednet xFrednet reopened this Jun 18, 2024
@xFrednet
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 18, 2024

📌 Commit c8a7e6e has been approved by xFrednet

It is now in the queue for this repository.

@xFrednet
Copy link
Member

YES!!! It worked, nice!

@bors
Copy link
Collaborator

bors commented Jun 18, 2024

⌛ Testing commit c8a7e6e with merge bd75e44...

@bors
Copy link
Collaborator

bors commented Jun 18, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing bd75e44 to master...

@bors bors merged commit bd75e44 into rust-lang:master Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve filtering options for Clippy's lint list
4 participants