Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit duplicated_attribute lint on "complex" cfgs #12555

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Don't emit duplicated_attribute lint on "complex" cfgs #12555

merged 1 commit into from
Mar 26, 2024

Conversation

GuillaumeGomez
Copy link
Member

Part of #12537.

changelog: Don't emit duplicated_attribute lint on "complex" cfgs

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 25, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 25, 2024
Closed
@GuillaumeGomez GuillaumeGomez force-pushed the duplicated_attribute branch 2 times, most recently from f46fa11 to 573ee37 Compare March 25, 2024 11:27
blyxyas
blyxyas approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️
We were too greedy trying to implement a pattern matching on a first iteration. Maybe in the future we can make a perfect algorithm (I don't see it as impossible)

Could you squash these commits?

@GuillaumeGomez
Copy link
Member Author

Sure, done!

@blyxyas
Copy link
Member

blyxyas commented Mar 26, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 26, 2024

📌 Commit e3f3a4b has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 26, 2024

⌛ Testing commit e3f3a4b with merge b8b9b27...

@bors
Copy link
Collaborator

bors commented Mar 26, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing b8b9b27 to master...

@bors bors merged commit b8b9b27 into rust-lang:master Mar 26, 2024
5 checks passed
@GuillaumeGomez GuillaumeGomez deleted the duplicated_attribute branch March 26, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @rustbot @blyxyas @bors