Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arithmetic_side_effects] Fix #10583 #10585

Merged
merged 1 commit into from
Apr 2, 2023
Merged

[arithmetic_side_effects] Fix #10583 #10585

merged 1 commit into from
Apr 2, 2023

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Apr 2, 2023

Fixes #10583

changelog: [`arithmetic_side_effects`]: Correctly handle division and module when the right-hand-side is unknown

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 2, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Apr 2, 2023

Thank you. @bors r+

@bors
Copy link
Collaborator

bors commented Apr 2, 2023

📌 Commit 05650b7 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 2, 2023

⌛ Testing commit 05650b7 with merge 8d83c15...

@bors
Copy link
Collaborator

bors commented Apr 2, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 8d83c15 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Apr 2, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 8d83c15 to master...

@bors bors merged commit 8d83c15 into rust-lang:master Apr 2, 2023
@bors bors mentioned this pull request Apr 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arithmetic_side_effects not triggering on potential divison by zero
4 participants
@c410-f3r @rustbot @Jarcho @bors