Move if condiction from then block out.

rust-lang · Jan 23, 2021 · cb1c415 · cb1c415
1 parent 2d1203d
commit cb1c415
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/clippy_lints/src/into_instead_of_from.rs b/clippy_lints/src/into_instead_of_from.rs
@@ -37,15 +37,14 @@ impl LateLintPass<'tcx> for IntoInsteadOfFrom {
                 if_chain! {
                     if let Some(tr_ref) = wbp.bounds[0].trait_ref();
                     if let Some(def_id) = tr_ref.trait_def_id();
+                    if cx.tcx.is_diagnostic_item(sym::from_trait, def_id);
                     then {
-                        if cx.tcx.is_diagnostic_item(sym::from_trait, def_id) {
-                            span_lint(
-                                cx,
-                                INTO_INSTEAD_OF_FROM,
-                                wp.span(),
-                                "What is WHERE PREDICATE"
-                            );
-                        }
+                        span_lint(
+                            cx,
+                            INTO_INSTEAD_OF_FROM,
+                            wp.span(),
+                            "What is WHERE PREDICATE"
+                        );
                     }
                 }
             },