Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document inclusive ranges. #1015

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Conversation

alercah
Copy link
Contributor

@alercah alercah commented Jan 24, 2018

This provides documentation for rust-lang/rust#28237.

@alercah
Copy link
Contributor Author

alercah commented Jan 24, 2018

Note that the failing build is due to using an un-stabilized feature; it should pass once the feature is stabilized and released.

This provides documentation for rust-lang/rust#28237.
@steveklabnik
Copy link
Member

steveklabnik commented Mar 16, 2018

These just landed as stable in nightly. Let's retry travis!

@alercah
Copy link
Contributor Author

alercah commented Mar 16, 2018

Looks like it's failing; is it running stable and/or not up to date with the nightly?

@marioidival
Copy link
Member

@frewsxcv
Copy link
Member

frewsxcv commented Mar 18, 2018

seems like we'll need to do one of three:

  • wait until it lands in stable rust, then merge
  • ...or update travis to use nightly rust
  • ...or update the code block to be rust,ignore

@steveklabnik thoughts?

@frewsxcv
Copy link
Member

actually, since rust-by-example now rides the docs release train, seems like it should be safe to do the second option and turn on nightly rust for travis ci

@steveklabnik
Copy link
Member

steveklabnik commented Mar 18, 2018

Yes, that's what we should do. Run with nightly but check there aren't any feature gates.

@alercah are you interested in tackling that? If not, I can take care of it tomorrow :)

@frewsxcv
Copy link
Member

looks good, thanks!

@frewsxcv frewsxcv merged commit 4747166 into rust-lang:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants