internal: ItemTree pretty-printing #8916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
May 21, 2021
|
|
||
| use crate::{db::DefDatabase, test_db::TestDB}; | ||
|
|
||
| fn check(ra_fixture: &str, expect: Expect) { |
There was a problem hiding this comment.
👍 thats perfect use case for expect!
|
bors r+ |
jonas-schievink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a printer for
ItemTreecontents, and a few tests to ensure thatItemTreelowering works like we expect it to. It also adds a new "Debug ItemTree" command that can be used to see theItemTreeof the currently open file. The pretty-printed output is usually close enough to Rust syntax that we can even use Rust syntax highlighting.This is similar to the old
ItemTreetests we had, but produces significantly more readable output, so these should actually carry their weight.