Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8 #7657

Merged
merged 8 commits into from
Feb 16, 2021
Merged

utf8 #7657

merged 8 commits into from
Feb 16, 2021

Conversation

matklad
Copy link
Member

@matklad matklad commented Feb 12, 2021

  • Prepare for utf-8 offsets
  • reduce code duplication in tests
  • Make utf8 default, implement utf16 in terms of it
  • Make it easy to add additional context for offset conversion
  • Implement utf8 offsets

closes #7453

@matklad
Copy link
Member Author

matklad commented Feb 12, 2021

Would be good to check this against some client!

@matklad
Copy link
Member Author

matklad commented Feb 16, 2021

bors r+

bors bot added a commit that referenced this pull request Feb 16, 2021
7657: utf8 r=matklad a=matklad

- Prepare for utf-8 offsets
- reduce code duplication in tests
- Make utf8 default, implement utf16 in terms of it
- Make it easy to add additional context for offset conversion
- Implement utf8 offsets

closes #7453

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 16, 2021

Build failed:

@matklad
Copy link
Member Author

matklad commented Feb 16, 2021

bors r+

bors bot added a commit that referenced this pull request Feb 16, 2021
7657: utf8 r=matklad a=matklad

- Prepare for utf-8 offsets
- reduce code duplication in tests
- Make utf8 default, implement utf16 in terms of it
- Make it easy to add additional context for offset conversion
- Implement utf8 offsets

closes #7453

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 16, 2021

Build failed:

@matklad
Copy link
Member Author

matklad commented Feb 16, 2021

gpf

@matklad
Copy link
Member Author

matklad commented Feb 16, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement utf-8 offsets extension from clangd
1 participant