Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement workspace/willRenameFiles for single-level file moves #7009

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Implement workspace/willRenameFiles for single-level file moves #7009

merged 1 commit into from
Dec 23, 2020

Conversation

kjeremy
Copy link
Contributor

@kjeremy kjeremy commented Dec 22, 2020

Automatically rename modules during file rename if they're in the same directory.

Fixes #6780

@kjeremy
Copy link
Contributor Author

kjeremy commented Dec 22, 2020

scratch-1608680004870

matklad
matklad reviewed Dec 23, 2020
View reviewed changes
Copy link
Member

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

crates/ide/src/lib.rs Outdated Show resolved Hide resolved
@kjeremy
Implement workspace/willRenameFiles for single-level file moves
4f989cf 
Renames modules during file rename if they're in the same directory.
@matklad
Copy link
Member

matklad commented Dec 23, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 23, 2020

Build succeeded:

@bors bors bot merged commit 3d5d21b into rust-lang:master Dec 23, 2020
@kjeremy kjeremy deleted the will-rename branch December 23, 2020 19:03
@GopherJ GopherJ mentioned this pull request Dec 31, 2020
Open
@ShuiRuTian ShuiRuTian mentioned this pull request Jan 9, 2021
Merged
bors bot added a commit that referenced this pull request Jan 13, 2021
@bors @ShuiRuTian
Merge #7220
42e0003 
7220: same level folder rename for will_rename_files r=kjeremy a=ShuiRuTian

use tricky way to support folder rename.

Another step after #7009 and for #4471

Co-authored-by: ShuiRuTian <158983297@qq.com>
Co-authored-by: Song Gao <158983297@qq.com>
@bjorn3 bjorn3 mentioned this pull request Jan 17, 2021
Closed
@lnicola lnicola mentioned this pull request Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP 3.16: Use workspace/willRenameFiles and/or worskspace/didRenameFiles to automatically rename modules
2 participants
@kjeremy @matklad