-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of lazy assits #4717
Conversation
# Conflicts: # crates/rust-analyzer/src/to_proto.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
Could you also add docs to lsp_extensions.md
?
# Conflicts: # crates/rust-analyzer/src/main_loop/handlers.rs # crates/rust-analyzer/src/to_proto.rs
@matklad Seems I've fixed the comments, now I will revert back the changes in extract_enum, so there will only be code related to the assist itself |
bors r+ |
@@ -202,6 +218,8 @@ impl Request for CodeActionRequest { | |||
pub struct CodeAction { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing pub diagnostics: Option<Vec<Diagnostic>>,
. In addition it is going to conflict with edit
in 3.16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don’t use diagnostics, so that’s why it is missing. What exactly changes in edit in 3.16?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore me. I was thinking of insert/replace edits in CompletionItem
No description provided.