-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Module name resolution #236
Conversation
Nice work! I didn't have time to tackle this earlier this week, but I enjoyed reading the PR. |
Some rough perf numbers:
This is for rust-lang/rust repo. Each
With these two optimizations implemented, I think that such top-down approach to name resolution would be speedy enough even with proper support for globs and macros (:crossed_fingers: ) |
Nice work! Are you planning to add tests as well? This seems quite tricky to get right... |
Not in this PR: this is covered by the completion tests atm. But yeah, we definitely should have nameres specific unit-tests. There's one in this PR for the start. We also should add a test which checks that we don't recompute item_map if user types inside function body. |
The main problem is that we've got an ICE... |
bors r+ |
Build succeeded |
work towards #231