Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lsp extension for cancelling running flychecks #13063

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Aug 19, 2022

Fixes #4828

@Veykril
Copy link
Member Author

Veykril commented Aug 19, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 19, 2022

📌 Commit 45b7b6a has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 19, 2022

⌛ Testing commit 45b7b6a with merge 04c487d...

@bors
Copy link
Collaborator

bors commented Aug 19, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 04c487d to master...

@bors bors merged commit 04c487d into rust-lang:master Aug 19, 2022
@Veykril Veykril deleted the stop-flycheck branch August 19, 2022 07:15
@RalfJung
Copy link
Member

This is awesome. :)

How do I trigger cancelling the running checks from the UI?

@Veykril
Copy link
Member Author

Veykril commented Aug 19, 2022

For VSCode, without any setup you'd need to bring up the command bar(? not sure if thats the name) via ctrl + shift + p and then type out Cancel running flychecks until you find that and invoke it.

The other way is to set up a keybinding to invoke the rust-analyzer.cancelFlycheck command

@Veykril
Copy link
Member Author

Veykril commented Aug 19, 2022

I wanted to make the small cargo check spinner in the status bar clickable but that thing is actually not managed by the r-a client at all so we don't have control over that 🙄 Will have to look into other options there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to abort/suspend "cargo check"
3 participants