Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe comparison traits (PartialEq, Eq, PartialOrd, Ord) #956

Closed
wants to merge 14 commits into from
Closed

Unsafe comparison traits (PartialEq, Eq, PartialOrd, Ord) #956

wants to merge 14 commits into from

Commits on Mar 9, 2015

  1. Add unsafe-cmp RFC

    @theemathas
    theemathas committed Mar 9, 2015
    Configuration menu
    Copy the full SHA
    fca3f6a View commit details
    Browse the repository at this point in the history

  2. Add properties of .le() and .ge()

    @theemathas
    theemathas committed Mar 9, 2015
    Configuration menu
    Copy the full SHA
    4f75eb6 View commit details
    Browse the repository at this point in the history

  3. Mention cross-crate transitivity issue as per @quantheory

    @theemathas
    theemathas committed Mar 9, 2015
    Configuration menu
    Copy the full SHA
    261b337 View commit details
    Browse the repository at this point in the history

  4. Add type parameter issue

    @theemathas
    theemathas committed Mar 9, 2015
    Configuration menu
    Copy the full SHA
    8c4ef29 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2015

  1. Explicitly mention that not many unsafes are required

    @theemathas
    theemathas committed Mar 10, 2015
    Configuration menu
    Copy the full SHA
    2cf814e View commit details
    Browse the repository at this point in the history

  2. Mention #[derive] in the summary

    @theemathas
    theemathas committed Mar 10, 2015
    Configuration menu
    Copy the full SHA
    d71228d View commit details
    Browse the repository at this point in the history

  3. Add Relaxed traits alternative

    @theemathas
    theemathas committed Mar 10, 2015
    Configuration menu
    Copy the full SHA
    22b9794 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2015

  1. Mention sort_by()

    @theemathas
    theemathas committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    768d6cc View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2015

  1. Add alternative as per @gankro

    @theemathas
    theemathas committed Mar 18, 2015
    Configuration menu
    Copy the full SHA
    7ca8fee View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2015

  1. Add drawback about accidentally incorrect code

    @theemathas
    theemathas committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    2b55259 View commit details
    Browse the repository at this point in the history

  2. Elaborate on alternatives

    @theemathas
    theemathas committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    589d19b View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2015

  1. Mention is_correct() alternative as per @huonw

    @theemathas
    theemathas committed Mar 22, 2015
    Configuration menu
    Copy the full SHA
    3818ec2 View commit details
    Browse the repository at this point in the history

  2. Mention associated constants in alternative

    @theemathas
    theemathas committed Mar 22, 2015
    Configuration menu
    Copy the full SHA
    52ec767 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2015

  1. Mention panics, as per @bluss

    @theemathas
    theemathas committed Mar 29, 2015
    Configuration menu
    Copy the full SHA
    58c893a View commit details
    Browse the repository at this point in the history