Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnamed fields of struct and union type #2102

Merged
merged 22 commits into from
Apr 9, 2018
Merged

Unnamed fields of struct and union type #2102

merged 22 commits into from
Apr 9, 2018

Commits on Aug 9, 2017

  1. Add unnamed fields RFC

    @joshtriplett
    joshtriplett committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    3946e44 View commit details
    Browse the repository at this point in the history

  2. Explicitly note that we cannot implement this as a macro

    @joshtriplett
    joshtriplett committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    a29c4b7 View commit details
    Browse the repository at this point in the history

  3. Mention alias mechanism as an alternative 

    Also discuss the drawbacks of that alternative.
    @joshtriplett
    joshtriplett committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    49466b1 View commit details
    Browse the repository at this point in the history

  4. Clarify the explanation of siginfo_t

    @joshtriplett
    joshtriplett committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    55ae14f View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2017

  1. Mention other interface issues this does not attempt to address 

    Deferred to future RFCs, in the interests of focusing on one problem at
a time.
    @joshtriplett
    joshtriplett committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    ca3ca0c View commit details
    Browse the repository at this point in the history

  2. Add an explanation of the mental model, with a diagram

    @joshtriplett
    joshtriplett committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    592b8b9 View commit details
    Browse the repository at this point in the history

  3. Per discussion, limit to repr(C) 

    While this feature potentially has value as a layout mechanism for Rust
data structures, it exists primarily to support native platform APIs.
Accordingly, limit its applicability to only repr(C) data structures.

Also document the use of `repr(packed)` with this mechanism.
    @joshtriplett
    joshtriplett committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    275a2c2 View commit details
    Browse the repository at this point in the history

  4. Document precedent for limiting to repr(C) 

    Variadic functions require extern "C".
    @joshtriplett
    joshtriplett committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    49db3d4 View commit details
    Browse the repository at this point in the history

  5. Add alternative syntax for declaring unnamed fields with named types 

    Suggested by Peter Atashian.
    @joshtriplett
    joshtriplett committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    bd37bd2 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2017

  1. Allow struct-in-struct and union-in-union

    @joshtriplett
    joshtriplett committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    bb350be View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2017

  1. Don't enumerate (a subset of) possible visibilities for fields

    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    bd98f9f View commit details
    Browse the repository at this point in the history

  2. Update summary and parsing section for struct-in-struct and union-in-… 

    …union
    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    3ce66a1 View commit details
    Browse the repository at this point in the history

  3. Change the syntax to use a field name of _

    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    e164166 View commit details
    Browse the repository at this point in the history

  4. Add a section on pattern matching

    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    45350b4 View commit details
    Browse the repository at this point in the history

  5. Explicitly state that the layout and alignment must match the C ABI 

    Keep the explanation for what that means in practice, but state the
more critical constraint up front.
    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    c7961d8 View commit details
    Browse the repository at this point in the history

  6. Allow unnamed fields with named types

    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    e504dd7 View commit details
    Browse the repository at this point in the history

  7. Clarify union field borrowing

    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    917e073 View commit details
    Browse the repository at this point in the history

  8. Explicitly add repr(C) in all examples 

    Since the feature requires `repr(C)`, the examples should reflect that.
    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    9e2f5f0 View commit details
    Browse the repository at this point in the history

  9. Only propagate repr(C); show how to write repr(packed) explicitly

    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    a826357 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2017

  1. Add a clarification for a corner case involving generics

    @joshtriplett
    joshtriplett committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    2ceb8e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. Explicitly prohibit type parameters as named types of unnamed fields

    @joshtriplett
    joshtriplett committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    adcdbf0 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2018

  1. RFC 2102

    @Centril
    Centril committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    1242d1a View commit details
    Browse the repository at this point in the history