Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete stray quote char. #1741

Merged
merged 1 commit into from
Sep 6, 2016
Merged

Delete stray quote char. #1741

merged 1 commit into from
Sep 6, 2016

Conversation

solson
Copy link
Member

@solson solson commented Sep 6, 2016

No description provided.

@eddyb eddyb merged commit 902e54c into rust-lang:master Sep 6, 2016
@solson solson deleted the patch-1 branch September 6, 2016 01:30
@nagisa
Copy link
Member

nagisa commented Sep 6, 2016

This quotation character probably shouldn’t have been deleted because it has a matching start quote at the start of the paragraph.


None of this would’ve happened if we all used “proper” quotes too :)

@solson
Copy link
Member Author

solson commented Sep 6, 2016

Heh, I did not notice the entire code block was nested inside a quotation. It would be better to block quote the entire section.

hadronized pushed a commit to hadronized/rfcs that referenced this pull request Feb 10, 2017
hadronized pushed a commit to hadronized/rfcs that referenced this pull request Feb 10, 2017
Fixes my mistake from rust-lang#1741. This also renders more obviously as a separate quotation.

r? @eddyb
@Centril Centril added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants