Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifetimes in arguments may be made longer #1720

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

aidanhs
Copy link
Member

@aidanhs aidanhs commented Aug 19, 2016

Followup based on #1716 (comment)

Sorry, I was going to add this in the first PR, but wanted feedback first - the merging was more eager than I expected!

I've left in "This is very unusual in Rust but it can happen." because I don't know if 'This' is meant to refer to a) lifetimes in function arguments, or b) the desire to make them longer.

ping @nikomatsakis

@nrc nrc added the T-lang Relevant to the language team, which will review and decide on the RFC. label Aug 20, 2016
@nikomatsakis
Copy link
Contributor

Really the language is imprecise. It is not true that it is only in a fn argument or only in a fn return type. It would be better to say: "This comes up (for example) in a type like fn(&'a u8), which may be safely treated as a fn(&'static u8)." or something like that.

@aidanhs
Copy link
Member Author

aidanhs commented Sep 6, 2016

Made suggested change.

@nikomatsakis nikomatsakis merged commit d8b2a73 into rust-lang:master Nov 11, 2016
@nikomatsakis
Copy link
Contributor

Thanks @aidanhs !

hadronized pushed a commit to hadronized/rfcs that referenced this pull request Feb 10, 2017
Lifetimes in arguments may be made longer
@Centril Centril added not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. A-borrowck Borrow checker related proposals & ideas labels Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-borrowck Borrow checker related proposals & ideas not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. T-lang Relevant to the language team, which will review and decide on the RFC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants