Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose core::intrinsics::abort as std::process::abort #1363

Closed
apasel422 opened this issue Nov 11, 2015 · 10 comments
Closed

Expose core::intrinsics::abort as std::process::abort #1363

apasel422 opened this issue Nov 11, 2015 · 10 comments
Labels
T-libs-api Relevant to the library API team, which will review and decide on the RFC.

Comments

@apasel422
Copy link
Contributor

This would be a safe wrapper around the intrinsic.

@nagisa
Copy link
Member

nagisa commented Nov 11, 2015

Semantics of this intrinsics are significantly more different compared to C
abort, so I'm not sure whether this implementation strategy is the best one
to take.
On Nov 11, 2015 2:29 AM, "Andrew Paseltiner" notifications@github.com
wrote:

This would be a safe wrapper around the intrinsic.


Reply to this email directly or view it on GitHub
#1363.

@Stebalien
Copy link
Contributor

I don't know the details of abort but I'd like some safe wrapper.

@Gankra
Copy link
Contributor

Gankra commented Nov 14, 2015

Even a stable wrapper would be grand :)

@nrc nrc added the T-libs-api Relevant to the library API team, which will review and decide on the RFC. label Aug 19, 2016
@fitzgen
Copy link
Member

fitzgen commented Mar 5, 2018

This would be super helpful for wasm stuff, where panics and aborts translate into traps either way, but panics pull in all the formatting and panicking infrastructure, which adds something like 30-40K to binary size.

Anything I can do to help push this forward?

@fitzgen
Copy link
Member

fitzgen commented Mar 5, 2018

Er wait, I'm not thinking of std::process::abort, which already exists.

I'm thinking of a stable core/#![no_std] story for abort. Maybe that is a separate issue somewhere?

@nagisa
Copy link
Member

nagisa commented Mar 5, 2018

rust-lang/rust#44489 is where you’d want to discuss panic infrastructure and it pulling in formatting machinery unnecessarily.

@Centril
Copy link
Contributor

Centril commented Oct 7, 2018

This is done since std::process::abort is stable.

@Centril Centril closed this as completed Oct 7, 2018
@nagisa
Copy link
Member

nagisa commented Oct 7, 2018

std::process::abort is stable, but it is not std::intrinsics::abort. It is not clear though if the original request was for a stable wrapper around std::intrinsics::abort or for anything that could be used like an abort.

@Centril
Copy link
Contributor

Centril commented Oct 7, 2018

@nagisa Weird, the documentation says: "The stabilized version of this intrinsic is std::process::abort".

https://doc.rust-lang.org/nightly/std/intrinsics/fn.abort.html

@Centril Centril reopened this Oct 7, 2018
@Centril
Copy link
Contributor

Centril commented Oct 7, 2018

Closing in favor of #2512.

@Centril Centril closed this as completed Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the RFC.
Projects
None yet
Development

No branches or pull requests

7 participants