Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document inclusive ranges. #215

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Conversation

alercah
Copy link
Contributor

@alercah alercah commented Jan 24, 2018

Provides the reference documentation for rust-lang/rust#28237.

Copy link
Contributor

@matthewjasper matthewjasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. The ... operator in the precedence table (expressions.md) also needs to be changed to ..=. Otherwise LGTM.

Will there be a stabilization PR for this soon?

```

Other forms of [range] \(`..` for an exclusive range, or any range with one or
both endpoints left unspecified) are not currently supported in matches.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that 'currently' is needed, the reference only talks about Rust at this point in time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I also remarked that ... is still accepted for backwards compatibility.

@alercah
Copy link
Contributor Author

alercah commented Jan 24, 2018

According to rust-lang/rust#28237, all that's left is docs, so hopefully once all my doc PRs are good it will be ready to go.

@alercah
Copy link
Contributor Author

alercah commented Jan 24, 2018

Note that the failing build is due to using an un-stabilized feature; it should pass once the feature is stabilized and released.

@matthewjasper
Copy link
Contributor

..= is stable now, can you fix the merge conflict so that this can be merged?

@alercah
Copy link
Contributor Author

alercah commented Mar 15, 2018

Done.

@steveklabnik steveklabnik removed the S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository label Mar 16, 2018
@steveklabnik
Copy link
Member

This just landed as stable in nightly. Let's restart travis!

@steveklabnik steveklabnik merged commit 3f5c9c9 into rust-lang:master Mar 16, 2018
@steveklabnik
Copy link
Member

🎊

@alercah alercah deleted the inclusive-ranges branch May 3, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants