Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Update error logging in borrow code #8

Closed
arora-aman opened this issue Jun 12, 2020 · 1 comment · Fixed by rust-lang/rust#84358
Closed

Update error logging in borrow code #8

arora-aman opened this issue Jun 12, 2020 · 1 comment · Fixed by rust-lang/rust#84358
Assignees
@ChrisPardy
Labels
diagnostics
Milestone
Feature complete

Comments

@arora-aman
Copy link
Member

arora-aman commented Jun 12, 2020 •
edited
Loading

Depends on #22 and #10
This was referenced Nov 23, 2020
Closed
Closed
Closed
@arora-aman arora-aman mentioned this issue Nov 30, 2020
Merged
7 tasks
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 12, 2020
@bors
Auto merge of rust-lang#79553 - sexxi-goose:mir_min_cap_writeback, r=…
5bd9b60 
…nikomatsakis

Capture precise paths in THIR and MIR

This PR allows THIR and MIR to use the result of the new capture analysis to actually capture precise paths

To achieve we:
- Writeback min capture results to TypeckResults
- Move handling upvars to PlaceBuilder in mir_build
- Lower precise paths in THIR build by reading min_captures
- Search for ancestors in min_capture when trying to build a MIR place which starts off of an upvar

Closes: rust-lang/project-rfc-2229#10

Partly implements: rust-lang/project-rfc-2229#18

Work that remains (not in this PR):
- [ ] [Known bugs when feature gate is enabled](https://github.com/rust-lang/project-rfc-2229/projects/1?card_filter_query=label%3Abug)
- [ ] Use min_capure_map for
  - [ ] Liveness analysis
  - [ ] rustc_mir/interpret/validity.rs
  - [ ] regionck
- [ ] rust-lang/project-rfc-2229#8
- [ ] remove closure_captures and upvar_capture_map

r? `@ghost`
@ChrisPardy ChrisPardy mentioned this issue Jan 16, 2021
Merged
@ChrisPardy ChrisPardy self-assigned this Jan 26, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jan 27, 2021
@Dylan-DPC
Rollup merge of rust-lang#81062 - sexxi-goose:precise_capture_diagnos…
8879a90 
…tics, r=nikomatsakis

Improve diagnostics for Precise Capture

This is just the capture analysis part and borrow checker logging will updated as part of rust-lang/project-rfc-2229#8

Closes rust-lang/project-rfc-2229#22
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jan 27, 2021
@Dylan-DPC
Rollup merge of rust-lang#81062 - sexxi-goose:precise_capture_diagnos…
6e50c94 
…tics, r=nikomatsakis

Improve diagnostics for Precise Capture

This is just the capture analysis part and borrow checker logging will updated as part of rust-lang/project-rfc-2229#8

Closes rust-lang/project-rfc-2229#22
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jan 28, 2021
@JohnTitor
Rollup merge of rust-lang#81062 - sexxi-goose:precise_capture_diagnos…
84ad95b 
…tics, r=nikomatsakis

Improve diagnostics for Precise Capture

This is just the capture analysis part and borrow checker logging will updated as part of rust-lang/project-rfc-2229#8

Closes rust-lang/project-rfc-2229#22
@nikomatsakis nikomatsakis added this to the Feature complete milestone Feb 17, 2021
@arora-aman arora-aman mentioned this issue Feb 23, 2021
Closed
@arora-aman
Copy link
Member Author

arora-aman commented Mar 8, 2021 •
edited
Loading

I think this will cover most for rust-lang/rust#76005

@ChrisPardy ChrisPardy mentioned this issue Apr 20, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 2, 2021
@Dylan-DPC
Rollup merge of rust-lang#84358 - sexxi-goose:print_captures_borrowck…
35c6902 
…_rebased, r=nikomatsakis

Update closure capture error logging for disjoint captures for disjoint captures

Improved error logging when `#![feature(capture_disjoint_fields)]` is used.

Closes rust-lang/project-rfc-2229#8
Closes rust-lang/project-rfc-2229#36
Closes rust-lang/project-rfc-2229#39
Closes rust-lang#76005
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 2, 2021
@Dylan-DPC
Rollup merge of rust-lang#84358 - sexxi-goose:print_captures_borrowck…
a00edce 
…_rebased, r=nikomatsakis

Update closure capture error logging for disjoint captures for disjoint captures

Improved error logging when `#![feature(capture_disjoint_fields)]` is used.

Closes rust-lang/project-rfc-2229#8
Closes rust-lang/project-rfc-2229#36
Closes rust-lang/project-rfc-2229#39
Closes rust-lang#76005
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChrisPardy ChrisPardy

Labels
diagnostics
Projects
None yet
Milestone
Feature complete
Development

Successfully merging a pull request may close this issue.

Update closure capture error logging for disjoint captures for disjoint captures sexxi-goose/rust
3 participants
@nikomatsakis @arora-aman @ChrisPardy