Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate -Zmiri-disable-abi-check #3071

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

RalfJung
Copy link
Member

This was added in #1776 but I couldn't find any discussion or motivation.

@RalfJung
Copy link
Member Author

Using github search, the only uses of this flag that I found are copies/forks of Miri itself.

@saethlin I recall you said in the past you didn't like our disable flags, so I assume you are in favor?

@oli-obk what do you think?

Copy link
Member

@saethlin saethlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I am in favor

@RalfJung
Copy link
Member Author

@bors r=oli-obk,saethlin

@bors
Copy link
Collaborator

bors commented Sep 21, 2023

📌 Commit f0f762e has been approved by oli-obk,saethlin

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 21, 2023

⌛ Testing commit f0f762e with merge 013c720...

@bors
Copy link
Collaborator

bors commented Sep 21, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk,saethlin
Pushing 013c720 to master...

@bors bors merged commit 013c720 into rust-lang:master Sep 21, 2023
8 checks passed
@RalfJung RalfJung deleted the deprecate-disable-abi branch September 22, 2023 05:28
bors added a commit that referenced this pull request Mar 6, 2024
remove the ability to disable ABI checking

This got deprecated in #3071, about half a year ago.

`@rust-lang/miri` I think it's fine to remove this now.
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Mar 9, 2024
remove the ability to disable ABI checking

This got deprecated in rust-lang/miri#3071, about half a year ago.

`@rust-lang/miri` I think it's fine to remove this now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants