Improve isatty support #2349
Merged
Improve isatty support #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Jul 9, 2022
RalfJung
reviewed
Jul 9, 2022
RalfJung
added
the
S-waiting-on-author
saethlin
force-pushed
the
isatty
branch
2 times, most recently
from
15efc5c
to
d673a32
Compare
oli-obk
reviewed
Jul 17, 2022
RalfJung
reviewed
Jul 17, 2022
RalfJung
reviewed
Jul 17, 2022
RalfJung
reviewed
Jul 17, 2022
RalfJung
reviewed
Jul 17, 2022
|
Is there anything that can be tested here? We should at least make sure this codepath is executed in |
RalfJung
reviewed
Jul 17, 2022
|
I'm currently tricking Miri into thinking it has a TTY by running |
|
Yeah we cannot check the return value of |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #2292 (comment), this is an attempt at
Since Unix -> Unix is very simple, I'm starting with a patch that just does that. Happy to augment/rewrite this based on feedback.
The linked file in libtest specifically only supports stdout. If we're doing this to support terminal applications, I think it would be strange to support one but not all 3 of the standard streams.
The
attycrate contains a bunch of extra logic that libtest does not contain, in order to support MSYS terminals: softprops/atty@db8d55f so I think if we're going to do Windows support, we should probably access all that logic somehow. I think it's pretty clear that the implementation is not going to change, so I think if we want to, pasting the contents of theattycrate into Miri is on the table, instead of taking a dependency.