make some things available for all Unixes #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit f43fecb has been approved by |
bors
added a commit
that referenced
this pull request
Jul 2, 2022
make some things available for all Unixes
|
💔 Test failed - checks-actions |
|
@bors r+ |
|
📌 Commit 5ba2c1e has been approved by |
bjorn3
reviewed
Jul 2, 2022
| @@ -42,7 +42,7 @@ fn test_posix_fadvise() { | |||
| assert_eq!(result, 0); | |||
| } | |||
|
|
|||
| #[cfg(any(target_os = "linux", target_os = "freebsd"))] | |||
There was a problem hiding this comment.
Why disable these tests on freebsd?
There was a problem hiding this comment.
They don't even build on freebsd. They use Linux-only libc symbols. I didn't catch this in #2221.
FreeBSD currently only runs a subset of the test suite since the target is still WIP, and this file is not one of them. But I wanted to make sure at least it builds.
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.