Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unix helpers #2226

Merged
merged 2 commits into from
Jun 12, 2022
Merged

Add unix helpers #2226

merged 2 commits into from
Jun 12, 2022

Conversation

b-ncMN
Copy link
Contributor

@b-ncMN b-ncMN commented Jun 11, 2022

This creates unix helper(s)

src/helpers.rs Show resolved Hide resolved
src/helpers.rs Show resolved Hide resolved
src/shims/dlsym.rs Outdated Show resolved Hide resolved
@b-ncMN b-ncMN force-pushed the unix-helpers branch 2 times, most recently from 615550f to 5d72669 Compare June 11, 2022 15:57
@RalfJung
Copy link
Member

This looks good! However, please rebase the PR on top of current master and also use assert_target_os_is_unix for getpid.

@b-ncMN b-ncMN force-pushed the unix-helpers branch 2 times, most recently from 0fa19df to f747cd8 Compare June 11, 2022 16:48
@b-ncMN b-ncMN changed the title Add target_os_is_unix helper Add unix helpers Jun 11, 2022
@RalfJung
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 12, 2022

📌 Commit bc27fbb has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented Jun 12, 2022

⌛ Testing commit bc27fbb with merge 96ee9a0...

@bors
Copy link
Collaborator

bors commented Jun 12, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 96ee9a0 to master...

@bors bors merged commit 96ee9a0 into rust-lang:master Jun 12, 2022
@bors bors mentioned this pull request Jun 12, 2022
@b-ncMN b-ncMN deleted the unix-helpers branch June 13, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants