Add support for artifact size events #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
changed the title
|
r? @wesleywiser |
wesleywiser
approved these changes
Jul 30, 2021
wesleywiser
approved these changes
Aug 2, 2021
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 19, 2021
…sleywiser Add support for artifact size profiling This adds support for profiling artifact file sizes (incremental compilation artifacts and query cache to begin with). Eventually we want to track this in perf.rlo so we can ensure that file sizes do not change dramatically on each pull request. This relies on support in measureme: rust-lang/measureme#169. Once that lands we can update this PR to not point to a git dependency. This was worked on together with `@michaelwoerister.` r? `@wesleywiser`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a new kind of
{Raw,Lightweight,}Event: integer events in order to support artifact size measurements. In the meantime it also refactors the other events to be more clearly about timestamps. Some code assumes timestamps, and this change makes it more clear where those assumptions are.In order to test this, using a compiler built with rust-lang/rust#87404 is necessary.
Here's what summarize produces now for artifact sizes:
