Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar line height issues in 0.3.6 #1168

Closed
DannyBen opened this issue Mar 19, 2020 · 3 comments · Fixed by #1182
Closed

Sidebar line height issues in 0.3.6 #1168

DannyBen opened this issue Mar 19, 2020 · 3 comments · Fixed by #1182
Labels
P-Blocker

Comments

@DannyBen
Copy link

Version 0.3.6 brought an undesired sidebar line height difference between the selected page and the rest of the links.

Screencast below.
screencast
@ehuss
Copy link
Contributor

ehuss commented Mar 19, 2020

Thanks for the report! @sergeypedan, #1137 seems to have broken sidebar spacing, can you take a look at a fix?

@ehuss ehuss mentioned this issue Apr 3, 2020
Merged
@ehuss
Copy link
Contributor

ehuss commented Apr 3, 2020

@DannyBen Can you try 0.3.7 and let me know if it works OK for you now?

@DannyBen
Copy link
Author

DannyBen commented Apr 3, 2020

Confirmed. Works beautifully now. Thanks for the quick fix.

DannyBen added a commit to DannyBen/runfile-book that referenced this issue Apr 3, 2020
@DannyBen
render with mdbook 0.3.7
3e6dd8b 
since rust-lang/mdBook#1168 was fixed
DannyBen added a commit to DannyBen/jobly-book that referenced this issue Apr 3, 2020
@DannyBen
render with mdbook 0.3.7
e40aab7 
since rust-lang/mdBook#1168 was fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sidebar line-height. ehuss/mdBook
3 participants
@ehuss @DannyBen @Dylan-DPC-zz