Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column numbers #581

Closed
wants to merge 1 commit into from
Closed

Add column numbers #581

wants to merge 1 commit into from

Conversation

printfn
Copy link

@printfn printfn commented Aug 26, 2023

This adds column numbers to logs, using the column! macro.

@Thomasdezeeuw
Copy link
Collaborator

Personally I would be against this change. I don't think it adds any benefits to the log messages, usually the lines numbers themselves are enough, I rarely see two log statements on the same line. Furthermore it would increase the binary sizes, something that people have been trying to reduce lately, see #569 and #575 for example.

@KodrAus
Copy link
Contributor

KodrAus commented Aug 28, 2023

Thanks for looking into this @printfn. I agree with @Thomasdezeeuw that we should be careful of adding more automatic data into log records. This is (one of the many) case we could support with structured logging, which we've just been discussing stabilizing in #328.

@printfn printfn closed this by deleting the head repository Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants