Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ToValue for String #438

Closed
wants to merge 1 commit into from
Closed

Implement ToValue for String #438

wants to merge 1 commit into from

Conversation

Thomasdezeeuw
Copy link
Collaborator

Using the str implementation.

@Thomasdezeeuw
Implement ToValue for String
3786056 
Using the str implementation.
@Thomasdezeeuw
Copy link
Collaborator Author

Nevermind I now see this has been moved behind the kv_unstable_std flag.

@Thomasdezeeuw Thomasdezeeuw deleted the string_to_value branch January 8, 2021 12:27
EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
@NobodyXu
Make binaries with required-features optional (rust-lang#438)
f482e36 
* Make binaries with `required-features` optional so that crates like `sccache` would work as expected.
* Fix `infer_bin_dir_template`: concat with `data.bin_path` introduced in rust-lang#417 
* Always `chmod +x $bin` on unix in case the archive (e.g. `sccache`) did not set the executable bit of fmt == Bin.
* CI: Install `sccache` but do not run it since it requires cargo env to be ready

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Thomasdezeeuw