Update android ndk version to latest LTS(r23c)

[tiann]

The latest LTS ndk version: https://developer.android.com/ndk/downloads

And the latest stable API version of Android is Android 12 (api=31)

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

[JohnTitor]

Let's give a try, @bors r+

[bors]

📌 Commit 501ce18 has been approved by JohnTitor

[bors]

⌛ Testing commit 501ce18 with merge 5df982c...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

Seems they removed the arch suffix from the URL.

[tiann]

The URL should be correct now.

[JohnTitor]

@bors r+

[bors]

📌 Commit 00f6fd9 has been approved by JohnTitor

[bors]

⌛ Testing commit 00f6fd9 with merge b40c31a...

[bors]

💔 Test failed - checks-actions

[tiann]

ndk23 remove *-ar, we should use llvm-ar instead: bbqsrc/cargo-ndk#38

[tiann]

on ndk23, there are two changes:

1. <arch>-ar is removed, it always use llvm-ar
2. only armeabi use gcc, all other arches use clang instead.

[JohnTitor]

@bors r+

[bors]

📌 Commit b205ce8 has been approved by JohnTitor

[tiann]

I checked it on https://www.shellcheck.net/, should be fine now

[JohnTitor]

@bors r+

[bors]

📌 Commit 4191221 has been approved by JohnTitor

[bors]

⌛ Testing commit 4191221 with merge f918cfd...

[bors]

💔 Test failed - checks-actions

[tiann]

Sorry....the ndk directory is incorrect :)

[JohnTitor]

@bors r+

[bors]

📌 Commit 4f172fb has been approved by JohnTitor

[bors]

⌛ Testing commit 4f172fb with merge cdc4ff7...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

Some items aren't matched between C and Rust on arm-linux-androideabi:

bad isalnum function pointer: rust: 2900728801 (0xace59be1) != c 2904805356 (0xad23cfec)
bad isalpha function pointer: rust: 2900728837 (0xace59c05) != c 2904805424 (0xad23d030)
bad iscntrl function pointer: rust: 2900728897 (0xace59c41) != c 2904805544 (0xad23d0a8)
bad isdigit function pointer: rust: 2900728933 (0xace59c65) != c 2904805624 (0xad23d0f8)
bad isgraph function pointer: rust: 2900728969 (0xace59c89) != c 2904805704 (0xad23d148)
bad islower function pointer: rust: 2900729005 (0xace59cad) != c 2904805784 (0xad23d198)
bad isprint function pointer: rust: 2900729041 (0xace59cd1) != c 2904805864 (0xad23d1e8)
bad ispunct function pointer: rust: 2900729077 (0xace59cf5) != c 2904805944 (0xad23d238)
bad isspace function pointer: rust: 2900729113 (0xace59d19) != c 2904806012 (0xad23d27c)
bad isupper function pointer: rust: 2900729149 (0xace59d3d) != c 2904806120 (0xad23d2e8)
bad isxdigit function pointer: rust: 2900729185 (0xace59d61) != c 2904806200 (0xad23d338)
bad isblank function pointer: rust: 2900728873 (0xace59c29) != c 2904806352 (0xad23d3d0)
bad tolower function pointer: rust: 2900729357 (0xace59e0d) != c 2904806432 (0xad23d420)
bad toupper function pointer: rust: 2900729385 (0xace59e29) != c 2904806524 (0xad23d47c)
bad field offset svm_zero of sockaddr_vm: rust: 12 (0xc) != c 13 (0xd)
bad field size svm_zero of sockaddr_vm: rust: 4 (0x4) != c 3 (0x3)
bad IPPROTO_MAX value at byte 0: rust: 0 (0x0) != c 7 (0x7)
bad NFNL_SUBSYS_COUNT value at byte 0: rust: 12 (0xc) != c 13 (0xd)

Is this expected?

[tiann]

Some items aren't matched between C and Rust on arm-linux-androideabi:

bad isalnum function pointer: rust: 2900728801 (0xace59be1) != c 2904805356 (0xad23cfec)
bad isalpha function pointer: rust: 2900728837 (0xace59c05) != c 2904805424 (0xad23d030)
bad iscntrl function pointer: rust: 2900728897 (0xace59c41) != c 2904805544 (0xad23d0a8)
bad isdigit function pointer: rust: 2900728933 (0xace59c65) != c 2904805624 (0xad23d0f8)
bad isgraph function pointer: rust: 2900728969 (0xace59c89) != c 2904805704 (0xad23d148)
bad islower function pointer: rust: 2900729005 (0xace59cad) != c 2904805784 (0xad23d198)
bad isprint function pointer: rust: 2900729041 (0xace59cd1) != c 2904805864 (0xad23d1e8)
bad ispunct function pointer: rust: 2900729077 (0xace59cf5) != c 2904805944 (0xad23d238)
bad isspace function pointer: rust: 2900729113 (0xace59d19) != c 2904806012 (0xad23d27c)
bad isupper function pointer: rust: 2900729149 (0xace59d3d) != c 2904806120 (0xad23d2e8)
bad isxdigit function pointer: rust: 2900729185 (0xace59d61) != c 2904806200 (0xad23d338)
bad isblank function pointer: rust: 2900728873 (0xace59c29) != c 2904806352 (0xad23d3d0)
bad tolower function pointer: rust: 2900729357 (0xace59e0d) != c 2904806432 (0xad23d420)
bad toupper function pointer: rust: 2900729385 (0xace59e29) != c 2904806524 (0xad23d47c)
bad field offset svm_zero of sockaddr_vm: rust: 12 (0xc) != c 13 (0xd)
bad field size svm_zero of sockaddr_vm: rust: 4 (0x4) != c 3 (0x3)
bad IPPROTO_MAX value at byte 0: rust: 0 (0x0) != c 7 (0x7)
bad NFNL_SUBSYS_COUNT value at byte 0: rust: 12 (0xc) != c 13 (0xd)

Is this expected?

Could you tell me how do i check this, any C header or the test code would be helpful.

[JohnTitor]

You could compare the actual definitions on C headers with the declarations on Rust. The errors say that they aren't matched.

[JohnTitor]

Closing as inactive, feel free to reopen/resubmit if you're still interested in this change. Thank you!