Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Improve library team mention message for consistency #395

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

yaahc
Copy link
Member

@yaahc yaahc commented Apr 12, 2022

Further continuations upon rust-lang/rust#95986.

I reviewed the output after the previous change to add the to_mention message for libs and wasn't thrilled with the output. It seemed to duplicate the welcome message that highfive posts generally as well as being very information dense. I've tried to reorder how we present information and reframe it so it flows well with the subsequent welcome message.

I tried reordering it all together so the welcome message comes first, but it appears that the self.set_assignee function needs to be called first before self.is_new_contributor or else some of the state within the Handler ends up being a python dict instead of the expected JSON... Didn't feel like debugging or refactoring that, but I think I've arrived upon a wording that looks good even if it comes first. Also this way I don't necessarily mess up other team's welcome messages that may already be optimal if placed first.

@yaahc
Copy link
Member Author

yaahc commented Apr 12, 2022

(fake) r? @Mark-Simulacrum

@Mark-Simulacrum Mark-Simulacrum merged commit d19ce5c into rust-lang:master Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants