Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax MSRV to 1.63.0 #457

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Relax MSRV to 1.63.0 #457

merged 1 commit into from
Aug 28, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Aug 23, 2023

No code changes are required, and this allows the current compiler
shipped by Debian stable (bookworm) to work. The only consideration is
that recent versions of allocator-api2 do require 1.64, but the
minimum dependency 0.2.9 is fine, and this is optional anyway.

@cuviper
Copy link
Member Author

cuviper commented Aug 23, 2023

This is motivated by hyperium/h2#698 (comment)

@Amanieu
Copy link
Member

Amanieu commented Aug 24, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 24, 2023

📌 Commit a139506 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 24, 2023

⌛ Testing commit a139506 with merge d08a129...

bors added a commit that referenced this pull request Aug 24, 2023
Relax MSRV to 1.63.0

No code changes are required, and this allows the current compiler
shipped by Debian stable (bookworm) to work. The only consideration is
that recent versions of `allocator-api2` do require 1.64, but the
minimum dependency 0.2.9 is fine, and this is optional anyway.
@bors
Copy link
Collaborator

bors commented Aug 24, 2023

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing d08a129 to master...

@bors
Copy link
Collaborator

bors commented Aug 24, 2023

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@Amanieu
Copy link
Member

Amanieu commented Aug 25, 2023

@bors retry

@bors
Copy link
Collaborator

bors commented Aug 25, 2023

⌛ Testing commit a139506 with merge e40432a...

bors added a commit that referenced this pull request Aug 25, 2023
Relax MSRV to 1.63.0

No code changes are required, and this allows the current compiler
shipped by Debian stable (bookworm) to work. The only consideration is
that recent versions of `allocator-api2` do require 1.64, but the
minimum dependency 0.2.9 is fine, and this is optional anyway.
@bors
Copy link
Collaborator

bors commented Aug 25, 2023

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Aug 27, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 27, 2023

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Aug 27, 2023

📌 Commit a139506 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 27, 2023

⌛ Testing commit a139506 with merge cdf7862...

bors added a commit that referenced this pull request Aug 27, 2023
Relax MSRV to 1.63.0

No code changes are required, and this allows the current compiler
shipped by Debian stable (bookworm) to work. The only consideration is
that recent versions of `allocator-api2` do require 1.64, but the
minimum dependency 0.2.9 is fine, and this is optional anyway.
@bors
Copy link
Collaborator

bors commented Aug 27, 2023

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing cdf7862 to master...

@bors
Copy link
Collaborator

bors commented Aug 27, 2023

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@bors
Copy link
Collaborator

bors commented Aug 27, 2023

☔ The latest upstream changes (presumably #463) made this pull request unmergeable. Please resolve the merge conflicts.

No code changes are required, and this allows the current compiler
shipped by Debian stable (bookworm) to work. The only consideration is
that recent versions of `allocator-api2` do require 1.64, but the
minimum dependency 0.2.9 is fine, and this is optional anyway.
@Amanieu
Copy link
Member

Amanieu commented Aug 28, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 28, 2023

📌 Commit 35e6124 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 28, 2023

⌛ Testing commit 35e6124 with merge f9e4900...

@bors
Copy link
Collaborator

bors commented Aug 28, 2023

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing f9e4900 to master...

@bors bors merged commit f9e4900 into rust-lang:master Aug 28, 2023
26 checks passed
@cuviper
Copy link
Member Author

cuviper commented Aug 29, 2023

Thanks! Could we get a release, so I can propagate this relaxation to indexmap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants