Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document bucket #365

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Document bucket #365

merged 3 commits into from
Feb 22, 2023

Conversation

JustForFun88
Copy link
Contributor

@JustForFun88 JustForFun88 commented Oct 8, 2022 •
edited
Loading

Well, I tried to make documentation for the bucket, and tried to do it correctly. But maybe I missed something. You can freely edit, add or even throw everything out if necessary 🙂.

JustForFun88
JustForFun88 commented Oct 8, 2022
View reviewed changes
src/map.rs
@@ -7533,6 +7533,7 @@ mod test_map {
}

#[test]
#[allow(clippy::needless_borrow)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because cargo clippy --all --tests --features serde,rayon,bumpalo -- -D clippy::all started returning an error

@bors
Copy link
Collaborator

bors commented Oct 12, 2022

☔ The latest upstream changes (presumably #366) made this pull request unmergeable. Please resolve the merge conflicts.

Amanieu
Amanieu reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@Amanieu Amanieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a few typos, I've corrected some of them but the same typos appear in other comments as well.

src/raw/mod.rs Outdated Show resolved Hide resolved
src/raw/mod.rs Outdated Show resolved Hide resolved
src/raw/mod.rs Outdated Show resolved Hide resolved
src/raw/mod.rs Outdated Show resolved Hide resolved
src/raw/mod.rs Outdated Show resolved Hide resolved
src/raw/mod.rs Outdated Show resolved Hide resolved
src/raw/mod.rs Outdated Show resolved Hide resolved
src/raw/mod.rs Outdated Show resolved Hide resolved
src/raw/mod.rs Outdated Show resolved Hide resolved
src/raw/mod.rs Outdated Show resolved Hide resolved
@Amanieu
Copy link
Member

Amanieu commented Oct 18, 2022

Overall, this looks great! Thanks for helping document the API!

@JustForFun88
Document bucket
9bd3c02 
Well, I tried to make documentation for the `basket`, and tried to do it correctly. But maybe I missed something. You can freely edit, add or even throw everything out if necessary.
@JustForFun88
Apply suggestions
136fccb
@JustForFun88
Copy link
Contributor Author

Hmm... new clippy lints. Ok I'll fix it tonight

@JustForFun88
Copy link
Contributor Author

There's quite a few typos, I've corrected some of them but the same typos appear in other comments as well.

I'm very sorry for the long break. Tried to make changes and corrections. Unfortunately, English is not my native language, so I apologize for possible mistakes and typos. Can you check again?

@Amanieu
Copy link
Member

Amanieu commented Feb 22, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 22, 2023

📌 Commit 8f53eb7 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 22, 2023

⌛ Testing commit 8f53eb7 with merge 7a4f5cc...

@bors
Copy link
Collaborator

bors commented Feb 22, 2023

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 7a4f5cc to master...

@bors bors merged commit 7a4f5cc into rust-lang:master Feb 22, 2023
@bors bors mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustForFun88 @bors @Amanieu