Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some memory issues around rebase #459

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Fix some memory issues around rebase #459

merged 2 commits into from
Aug 20, 2019

Conversation

carlosmn
Copy link
Contributor

Fixes #457

@carlosmn
rebase: keep track of the rewrite_notes_ref string
ce6a1ef 
We can't just take the pointer, as Rust won't know to free it when the options
struct will go out of scope.
@carlosmn
rebase: no need to forget the options
7ded117 
We don't have anything to drop.
@alexcrichton alexcrichton merged commit d94e4f1 into rust-lang:master Aug 20, 2019
@alexcrichton
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory errors in RebaseOptions
2 participants
@carlosmn @alexcrichton