Wrap callbacks in struct fields in Option
#453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointed out by nightly rustc we're accidentally relying on undefined behavior right now by calling `mem::zeroed` on structs which internally contain non-nullable function references. Let's instead wrap everything in `Option` so the zero bit pattern is valid for these structs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed out by nightly rustc we're accidentally relying on undefined
behavior right now by calling
mem::zeroedon structs which internallycontain non-nullable function references. Let's instead wrap everything
in
Optionso the zero bit pattern is valid for these structs.