Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: implement git_repository_commondir #1079

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

st3iny
Copy link
Contributor

@st3iny st3iny commented Aug 21, 2024

Hey folks, thanks for maintaining bindings to libgit2.

I implemented git_repository_commondir because I'm currently using it in a side project.

I'm an open source maintainer/developer myself so I know the game. Critical and honest feedback is always welcome.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed a small change to include the short-line for the documentation. Usually the first line should be a short description of what the function does.

@ehuss ehuss enabled auto-merge August 21, 2024 20:32
@ehuss ehuss added this pull request to the merge queue Aug 21, 2024
Merged via the queue into rust-lang:master with commit 2e0fcda Aug 21, 2024
7 checks passed
@st3iny st3iny deleted the repo/commondir branch August 22, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants