Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with rust's linkchecker and mdbook. #147

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 27, 2019

The linkchecker in the rust repo rejects this because there are duplicate
HTML id's. The theme selector uses the id "rust" for the Rust color theme.
See rust-lang/mdBook#880 for more info.

This blocks updating upstream.

@Centril
Copy link
Contributor

Centril commented Feb 28, 2019

I gave you write access to the repo since you've been contributing a lot. Feel free to merge when you deem appropriate.

@ehuss ehuss merged commit 6f7ba84 into rust-lang:master Feb 28, 2019
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 28, 2019
Update edition-guide

15 commits in 419edb885ec1a98c0747b3907003d79e3e6b93a9..5f3cc2a5618700efcde3bc00799744f21fa9ad2e
2018-12-04 16:43:38 -0500 to 2019-02-27 20:11:50 -0800
- Migrate to mdbook 0.2. (rust-lang/edition-guide#152)
- Remove automatic deployment. (rust-lang/edition-guide#151)
- Fix issue with rust's linkchecker and mdbook. (rust-lang/edition-guide#147)
- Fix test now that overflowing_literals is rejected in all editions. (rust-lang/edition-guide#148)
- overflowing_literals is deny on all editions (rust-lang/edition-guide#146)
- Update for uniform_path stabilization. (rust-lang/edition-guide#141)
- Add example to rustup to show overriding to specific version (rust-lang/edition-guide#144)
- Update for anonymous-lifetime stabilization. (rust-lang/edition-guide#142)
- Add minimum Rust version for Kleene operator (rust-lang/edition-guide#137)
- Add 2018-specific changes. (rust-lang/edition-guide#130)
- aborting-on-panic.md: Typo in example config (rust-lang/edition-guide#125)
- Clarify uniform paths are not yet in Rust 2018 (rust-lang/edition-guide#124)
- update several version numbers
- Fixes outdated link (rust-lang/edition-guide#131)
- Fixed typo in transitioning page. (rust-lang/edition-guide#127)
bors added a commit to rust-lang/rust that referenced this pull request Mar 1, 2019
Update edition-guide

15 commits in 419edb885ec1a98c0747b3907003d79e3e6b93a9..5f3cc2a5618700efcde3bc00799744f21fa9ad2e
2018-12-04 16:43:38 -0500 to 2019-02-27 20:11:50 -0800
- Migrate to mdbook 0.2. (rust-lang/edition-guide#152)
- Remove automatic deployment. (rust-lang/edition-guide#151)
- Fix issue with rust's linkchecker and mdbook. (rust-lang/edition-guide#147)
- Fix test now that overflowing_literals is rejected in all editions. (rust-lang/edition-guide#148)
- overflowing_literals is deny on all editions (rust-lang/edition-guide#146)
- Update for uniform_path stabilization. (rust-lang/edition-guide#141)
- Add example to rustup to show overriding to specific version (rust-lang/edition-guide#144)
- Update for anonymous-lifetime stabilization. (rust-lang/edition-guide#142)
- Add minimum Rust version for Kleene operator (rust-lang/edition-guide#137)
- Add 2018-specific changes. (rust-lang/edition-guide#130)
- aborting-on-panic.md: Typo in example config (rust-lang/edition-guide#125)
- Clarify uniform paths are not yet in Rust 2018 (rust-lang/edition-guide#124)
- update several version numbers
- Fixes outdated link (rust-lang/edition-guide#131)
- Fixed typo in transitioning page. (rust-lang/edition-guide#127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants