run coverage before doc-build so it doesn't delete the docs that were just built #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphar
added
the
S-waiting-on-review
… just built related issue: rust-lang/cargo#9447
jyn514
approved these changes
May 2, 2021
| // we have to run coverage before the doc-build because currently it | ||
| // deletes the doc-target folder. | ||
| // https://github.com/rust-lang/cargo/issues/9447 | ||
| let doc_coverage = match self.get_coverage(target, build, metadata, limits) { |
There was a problem hiding this comment.
Do you mind adding a build test that coverage is generated? Maybe it could look at the /crate page and see if there's a % sign somewhere (see https://docs.rs/crate/tokio/1.5.0 for an example of what that looks like).
There was a problem hiding this comment.
I'll add a test.
Instead of checking the HTML output I would propose we just check if the coverage is in the database, which is good enough to know if the build with coverage worked, right?
There was a problem hiding this comment.
@jyn514 I added the assertion to the build-test
syphar
added
S-waiting-on-author
syphar
force-pushed
the
reorder-coverage
branch
2 times, most recently
from
387234a
to
0cde41c
Compare
syphar
added
S-waiting-on-review
jyn514
approved these changes
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: rust-lang/cargo#9447