Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by downloads without letter restriction #102

Merged
merged 1 commit into from
Jan 3, 2015
Merged

Sort by downloads without letter restriction #102

merged 1 commit into from
Jan 3, 2015

Conversation

markberger
Copy link
Contributor

  • 'Browse All Crates' links to all crates instead of all
    crates that start with the letter A.
  • Changing the 'Sort by' param returns the user to the first page.
  • Crates pagination only shows the surrounding 9 pages instead
    of all possible pages.

Closes #44.

@markberger
Copy link
Contributor Author

Here is what the new pagination looks like:

pagination-start

pagination-middle

pagination-end

alexcrichton
alexcrichton reviewed Jan 1, 2015
View reviewed changes
app/templates/crates.hbs
@@ -59,7 +60,7 @@
{{#link-to 'crates' (query-params page=prevPage) class="prev"}}
<img src="/assets/left-pag.png"/>
{{/link-to}}
{{#each pages}}
{{#each surroundingPages}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this should probably be done for all pagination, so you may just want to merge the surroundingPages method into pages. If we need to we can add an allPages method later on.

@markberger
Sort by downloads without letter restriction
c78f4a7 
* 'Browse All Crates' links to all crates instead of all
  crates that start with the letter A.
* Changing the 'Sort by' param returns the user to the first page.
* Crates pagination only shows the surrounding 9 pages instead
  of all possible pages.

Closes #44.
@alexcrichton
Copy link
Member

This looks great, thanks! Also, feel free to ping the PR whenever it's updated, sadly github doesn't send out notifications for force-pushes :(.

Would it be possible to have some ... tokens in the nav to show that there are more pages to the left and the right? When looking at:

https://i.imgur.com/h2Dr297.png

It's not super clear that there are pages to the right, or how many pages there are. It may be tough to get too fancy here, though, but curious what you think about that.

@markberger
Copy link
Contributor Author

Something like the Github pagination?

screen shot 2015-01-02 at 9 56 43 pm

I'm not opposed to having ... to signify there are more pages. To be honest, I'm not much of a UI expert so I usually see what other sites are doing and copy them 😜. Google and Bing both use the system Crates.io has right now:

screen shot 2015-01-02 at 10 00 57 pm

screen shot 2015-01-02 at 10 01 29 pm

Also Crates.io does show the total number of packages in front of the user in the top left-hand corner:

screen shot 2015-01-02 at 10 03 12 pm

However, the ... would definitely be clearer. Ultimately, I don't have a major preference for either one.

@alexcrichton
Copy link
Member

Eh, it looks like this has some good precedent, so I'm fine by that!

@alexcrichton
Copy link
Member

Thanks again!

alexcrichton added a commit that referenced this pull request Jan 3, 2015
@alexcrichton
Merge pull request #102 from markberger/sort-by-downloads
b505685 
Sort by downloads without letter restriction
@alexcrichton alexcrichton merged commit b505685 into rust-lang:master Jan 3, 2015
bors added a commit that referenced this pull request Dec 17, 2019
@bors
Auto merge of #1968 - rust-lang:dependabot/npm_and_yarn/ember-cli-ugl…
9be7be2 
…ify-3.0.0, r=Turbo87

Bump ember-cli-uglify from 2.0.0 to 3.0.0

Bumps [ember-cli-uglify](https://github.com/ember-cli/ember-cli-uglify) from 2.0.0 to 3.0.0.
<details>
<summary>Release notes</summary>

*Sourced from [ember-cli-uglify's releases](https://github.com/ember-cli/ember-cli-uglify/releases).*

> ## v3.0.0
> #### 💥 Breaking Change
> * [#102](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/102) Drop support for Node.js 6 ([@&#8203;Turbo87](https://github.com/Turbo87))
> * [#64](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/64) Drop support for Node.js 4 ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### 🏠 Internal
> * [#68](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/68) TravisCI: Remove deprecated `sudo: false` option ([@&#8203;Turbo87](https://github.com/Turbo87))
> * [#67](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/67) Remove unneeded and confusing dependency ([@&#8203;jelhan](https://github.com/jelhan))
> * [#66](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/66) CI: Run only for `master` branch, tags and PRs ([@&#8203;Turbo87](https://github.com/Turbo87))
> * [#44](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/44) Fix CI ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 2
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - jelhan ([@&#8203;jelhan](https://github.com/jelhan))
</details>
<details>
<summary>Changelog</summary>

*Sourced from [ember-cli-uglify's changelog](https://github.com/ember-cli/ember-cli-uglify/blob/master/CHANGELOG.md).*

> ## v3.0.0 (2019-04-12)
>
> #### 💥 Breaking Change
> * [#102](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/102) Drop support for Node.js 6 ([@&#8203;Turbo87](https://github.com/Turbo87))
> * [#64](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/64) Drop support for Node.js 4 ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### 🏠 Internal
> * [#68](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/68) TravisCI: Remove deprecated `sudo: false` option ([@&#8203;Turbo87](https://github.com/Turbo87))
> * [#67](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/67) Remove unneeded and confusing dependency ([@&#8203;jelhan](https://github.com/jelhan))
> * [#66](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/66) CI: Run only for `master` branch, tags and PRs ([@&#8203;Turbo87](https://github.com/Turbo87))
> * [#44](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/44) Fix CI ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 2
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - jelhan ([@&#8203;jelhan](https://github.com/jelhan))
>
>
> ## v2.1.0 (2018-03-27)
>
> #### 🚀 Enhancement
> * [#37](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/37) Run uglify in parallel ([@&#8203;mikrostew](https://github.com/mikrostew))
>
> #### Committers: 1
> - Michael Stewart ([@&#8203;mikrostew](https://github.com/mikrostew))
>
>
> ## v2.0.2 (2018-02-20)
>
> #### 🚀 Enhancement
> * [#34](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/34) Updates broccoli-uglify-sourcemap to version 2.0.1 ([@&#8203;Duder-onomy](https://github.com/Duder-onomy))
>
> #### 🏠 Internal
> * [#36](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/pull/36) add test (basically, a default app built’s tests run even post uglifi… ([@&#8203;stefanpenner](https://github.com/stefanpenner))
>
> #### Committers: 2
> - Greg Larrenaga ([@&#8203;Duder-onomy](https://github.com/Duder-onomy))
> - Stefan Penner ([@&#8203;stefanpenner](https://github.com/stefanpenner))
</details>
<details>
<summary>Commits</summary>

- [`430cb9a`](ember-cli/ember-cli-terser@430cb9a) v3.0.0
- [`9540447`](ember-cli/ember-cli-terser@9540447) Update Changelog
- [`b051655`](ember-cli/ember-cli-terser@b051655) Build(deps-dev): Bump ember-cli from 3.8.2 to 3.9.0 ([#104](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/issues/104))
- [`940606d`](ember-cli/ember-cli-terser@940606d) Build(deps-dev): Bump ember-source from 3.9.0 to 3.9.1
- [`10199ef`](ember-cli/ember-cli-terser@10199ef) Merge pull request [#102](https://github-redirect.dependabot.com/ember-cli/ember-cli-uglify/issues/102) from Turbo87/node-6
- [`84fed8a`](ember-cli/ember-cli-terser@84fed8a) Build(deps-dev): Bump ember-cli from 3.8.1 to 3.8.2
- [`9cdbcf2`](ember-cli/ember-cli-terser@9cdbcf2) Drop support for Node 6
- [`9ed7828`](ember-cli/ember-cli-terser@9ed7828) Build(deps-dev): Bump ember-source from 3.8.0 to 3.9.0
- [`d778b8a`](ember-cli/ember-cli-terser@d778b8a) Build(deps-dev): Bump ember-cli-babel from 7.6.0 to 7.7.3
- [`bd30ff4`](ember-cli/ember-cli-terser@bd30ff4) Build(deps): Bump broccoli-uglify-sourcemap from 3.0.0 to 3.1.0
- Additional commits viewable in [compare view](ember-cli/ember-cli-terser@v2.0.0...v3.0.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-cli-uglify&package-manager=npm_and_yarn&previous-version=2.0.0&new-version=3.0.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-cli-uglify&package-manager=npm_and_yarn&previous-version=2.0.0&new-version=3.0.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
bors added a commit that referenced this pull request Dec 17, 2019
@bors
Auto merge of #1963 - rust-lang:dependabot/npm_and_yarn/ember-keyboar…
096cd22 
…d-5.0.0, r=Turbo87

Bump ember-keyboard from 4.0.0 to 5.0.0

Bumps [ember-keyboard](https://github.com/patience-tema-baron/ember-keyboard) from 4.0.0 to 5.0.0.
<details>
<summary>Release notes</summary>

*Sourced from [ember-keyboard's releases](https://github.com/patience-tema-baron/ember-keyboard/releases).*

> ## upgrade ember-cli-babel
> upgrades to ember-cli-babel 7.
</details>
<details>
<summary>Commits</summary>

- [`cba9aef`](adopted-ember-addons/ember-keyboard@cba9aef) bump
- [`0ba6863`](adopted-ember-addons/ember-keyboard@0ba6863) Merge pull request [#94](https://github-redirect.dependabot.com/patience-tema-baron/ember-keyboard/issues/94) from Gaurav0/babel_7
- [`63f013b`](adopted-ember-addons/ember-keyboard@63f013b) Merge pull request [#102](https://github-redirect.dependabot.com/patience-tema-baron/ember-keyboard/issues/102) from gabrielgrant/patch-1
- [`ddb0f11`](adopted-ember-addons/ember-keyboard@ddb0f11) Update README to fix docs link
- [`32df04e`](adopted-ember-addons/ember-keyboard@32df04e) Merge pull request [#98](https://github-redirect.dependabot.com/patience-tema-baron/ember-keyboard/issues/98) from MelSumner/patch-1
- [`6b7a740`](adopted-ember-addons/ember-keyboard@6b7a740) Update README.md
- [`2d3a8af`](adopted-ember-addons/ember-keyboard@2d3a8af) Upgrade to babel 7
- See full diff in [compare view](adopted-ember-addons/ember-keyboard@v4.0.0...v5.0.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-keyboard&package-manager=npm_and_yarn&previous-version=4.0.0&new-version=5.0.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-keyboard&package-manager=npm_and_yarn&previous-version=4.0.0&new-version=5.0.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
Turbo87 pushed a commit to Turbo87/crates.io that referenced this pull request Jan 4, 2023
@renovate
Update Swatinem/rust-cache action to v2.0.1 (rust-lang#102)
8a09c2d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sorting by downloads
2 participants
@markberger @alexcrichton